Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example admonition css to example build #1284

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

kescobo
Copy link
Contributor

@kescobo kescobo commented Apr 9, 2020

Pseudo-document custom CSS for admonitions in example build. Re: #1280

I wasn't sure how to test this build locally, but I'm ~92% sure it should work :-)

@mortenpi
Copy link
Member

mortenpi commented Apr 9, 2020

LGTM, thanks a lot!

I wasn't sure how to test this build locally, but I'm ~92% sure it should work :-)

I can report that the posterior probability here is 100% 🙂

These test examples can be built by just calling julia --project test/examples/make.jl (although the environment also needs the test dependencies). Alternatively, they also get built during testing.

@mortenpi mortenpi merged commit 8be1a8e into JuliaDocs:master Apr 9, 2020
briochemc added a commit to briochemc/Documenter.jl that referenced this pull request Apr 10, 2020
* JuliaDocs-master: (138 commits)
  Add example admonition css to example build (JuliaDocs#1284)
  Pass non-standard admonition categories on in HTML output (JuliaDocs#1280)
  Suggest using the `aligned` environment (JuliaDocs#1275)
  Update DiffEq docs link (JuliaDocs#1274)
  Make Deps.pip a closure again (JuliaDocs#1240)
  Recommend Julia 1.4 in the manual (JuliaDocs#1272)
  Add note about doctests in docstrings (JuliaDocs#1265)
  Fix minted/lstlistings escaping (JuliaDocs#1269)
  Changelog for 0.24.7 (JuliaDocs#1266)
  Test with Julia 1.4 instead of 1.3 on CI (JuliaDocs#1268)
  Fix doctest testing on nightly (JuliaDocs#1267)
  remove "only" from search stop word filter (JuliaDocs#1264)
  Reorganize some Sass variables to make theming easier (JuliaDocs#1258)
  Fix outdated links in the manual (JuliaDocs#1255)
  Fix LaTeX tests for tags (JuliaDocs#1256)
  Install TagBot as a GitHub Action (JuliaDocs#1237)
  use Julia 1.3 for .travis hosting example (JuliaDocs#1235)
  Set version to 0.24.5 (JuliaDocs#1233)
  Support REPL softscope for Julia 1.5. (JuliaDocs#1232)
  Discourage use of matrix: in Travis conf (JuliaDocs#1231)
  ...
@kescobo kescobo deleted the customadmonition branch April 11, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants