Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mktempdir bug on Julia > 1.3. #1194

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Fix mktempdir bug on Julia > 1.3. #1194

merged 2 commits into from
Nov 25, 2019

Conversation

fredrikekre
Copy link
Member

No description provided.

@mortenpi mortenpi added this to the 0.24.1 milestone Nov 25, 2019
@mortenpi mortenpi added Format: LaTeX Related to the LaTeX / PDF output Type: Bug labels Nov 25, 2019
@mortenpi mortenpi merged commit a36215c into master Nov 25, 2019
@mortenpi mortenpi deleted the fe/latex branch November 25, 2019 06:53
@mortenpi
Copy link
Member

LGTM. Isn't this a breaking change in Julia though..?

@fredrikekre
Copy link
Member Author

No, just me assuming that the cleanup kwarg was implemented for all mktempdir methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi Awaiting requested review from mortenpi

Assignees
No one assigned
Labels
Format: LaTeX Related to the LaTeX / PDF output Type: Bug
Projects
None yet
Milestone
0.24.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @mortenpi