Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check env vars for non-Travis CI platforms #1067
Check env vars for non-Travis CI platforms #1067
Changes from all commits
42af534
1cb28eb
7467920
2986dab
b970a99
e48fafa
3bef32b
2175bb1
b3b409b
06422a8
b4c7620
1ef6c5c
17acc66
0dea970
26c5aff
edbf343
4ee8b8f
cd753ed
f58f06f
07bca34
588fc01
e550502
844d1f4
61ecc09
7a256b8
51eb94f
9d3f16e
338d05d
d623f78
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, for a more cleaner API here, it would be better if
read_ci_env
would just returnnothing
if the CI env can not be detected? That way the call sites do not have to do thehaskey(ENV, "CI")
check, which may actually be different on different CI systems (in general). So instead, they would check if this returnednothing
or not, and decide whether we're in CI based on that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not actually returning anything?