-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert video HTML tag for images ending with ".webm" #1034
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
reviewed
Jun 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Basically, an oversight that we already don't support this.
Markdown image elements like `![Alt video text](dir/video.webm)` will be rendered with a video HTML element in a similar way to Gitlab markdown.
Thanks for the feedback. I was on holiday, so couldn't respond straight away. |
mortenpi
reviewed
Jun 16, 2019
@richiejp Thanks for the contribution! Will merge once the tests complete. |
richiejp
pushed a commit
to richiejp/jdp
that referenced
this pull request
Jul 2, 2019
Hopefully temporary change while waiting for documenter to merge PR. JuliaDocs/Documenter.jl#1034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown elements like
![Alt video text](dir/video.webm)
will be insertedwith a video HTML element in a similar way to Gitlab markdown.