Set GIT_TEMPLATE_DIR when calling Git #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
added a commit
that referenced
this pull request
Jul 6, 2022
(cherry picked from commit f8ba5ce)
Merged
mortenpi
added a commit
that referenced
this pull request
Jul 6, 2022
Relative to the original commit, the call to isnothing() has been replaced with === nothing, to support Julia 1.0. (cherry picked from commit f8ba5ce)
mortenpi
added a commit
that referenced
this pull request
Jul 7, 2022
Relative to the original commit, to support Julia 1.0: * the call to isnothing() has been replaced with === nothing * a compatibility definition for addenv() has been added (cherry picked from commit f8ba5ce)
mortenpi
added a commit
that referenced
this pull request
Jul 7, 2022
Relative to the original commit, to support Julia 1.0: * the call to isnothing() has been replaced with === nothing * a compatibility definition for addenv() has been added (cherry picked from commit f8ba5ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for Git to pick up user templates and hooks, which can have unexpected effects on Git's behavior. By setting
GIT_TEMPLATE_DIR, we should be able to avoid that.This fix actually originally prompted #1855, so this is a simpler and safer alternative to that PR which doesn't bring in the dependency. But it does set everything up for moving to Git.jl (which might be worth doing in a minor release) by introducing the
git()wrapper function.