Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GIT_TEMPLATE_DIR when calling Git #1862

Merged
merged 10 commits into from
Jul 6, 2022
Merged

Set GIT_TEMPLATE_DIR when calling Git #1862

merged 10 commits into from
Jul 6, 2022

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Jul 4, 2022

It's possible for Git to pick up user templates and hooks, which can have unexpected effects on Git's behavior. By setting GIT_TEMPLATE_DIR, we should be able to avoid that.

This fix actually originally prompted #1855, so this is a simpler and safer alternative to that PR which doesn't bring in the dependency. But it does set everything up for moving to Git.jl (which might be worth doing in a minor release) by introducing the git() wrapper function.

@mortenpi mortenpi merged commit f8ba5ce into master Jul 6, 2022
@mortenpi mortenpi deleted the mp/git-template-dir branch July 6, 2022 05:15
mortenpi added a commit that referenced this pull request Jul 6, 2022
@mortenpi mortenpi mentioned this pull request Jul 6, 2022
mortenpi added a commit that referenced this pull request Jul 6, 2022
Relative to the original commit, the call to isnothing() has been
replaced with === nothing, to support Julia 1.0.

(cherry picked from commit f8ba5ce)
mortenpi added a commit that referenced this pull request Jul 7, 2022
Relative to the original commit, to support Julia 1.0:

* the call to isnothing() has been replaced with === nothing
* a compatibility definition for addenv() has been added

(cherry picked from commit f8ba5ce)
mortenpi added a commit that referenced this pull request Jul 7, 2022
Relative to the original commit, to support Julia 1.0:

* the call to isnothing() has been replaced with === nothing
* a compatibility definition for addenv() has been added

(cherry picked from commit f8ba5ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant