Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI color tweaks #1629

Closed
fredrikekre opened this issue Jul 6, 2021 · 5 comments · Fixed by #1647
Closed

ANSI color tweaks #1629

fredrikekre opened this issue Jul 6, 2021 · 5 comments · Fixed by #1647
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Milestone

Comments

@fredrikekre
Copy link
Member

I think in dark mode things look great, but in light mode yellow, light_gray and light_yellow are very hard to see

Screenshot from 2021-07-06 16-42-42
Screenshot from 2021-07-06 16-43-44

@fredrikekre
Copy link
Member Author

cc @kimikage

@mortenpi mortenpi added Type: Enhancement Format: HTML Related to the default HTML output labels Jul 6, 2021
@kimikage
Copy link
Contributor

kimikage commented Jul 9, 2021

I was initially thinking of adjusting the color scheme of Documenter itself. (Whether my proposal is good or bad, I feel that the caption of Tip Admonition has too low contrast.)
admonition
However, I am skeptical about such a color scheme change should be made in the patch version.
So, I think we have roughly three options:

  1. tweak the ANSI colors only
  2. tweak the basic color scheme, make the admonition colors look like the current scheme, and tweak the ANSI colors
  3. tweak the basic color scheme (including the admonition colors) and the ANSI colors

@kimikage
Copy link
Contributor

I am busy for a while and am not at the stage where I can propose a new color scheme for Documenter yet. However, I would like to make a preliminary proposal for the part about ANSI colors. (Hopefully this weekend.)

I'm not really interested in changing the appearance of Documenter's default theme, I'm more interested in updating the theme to make it easier to customize.

@kimikage
Copy link
Contributor

@mortenpi mortenpi added this to the 0.27.4 milestone Jul 19, 2021
@mortenpi
Copy link
Member

I think the color scheme you're proposing @kimikage is a nice improvement over the current one, especially in the light theme. On the other hand, it is a perhaps noticeable, but not a major overhaul of the colors, so I would not mind having it in a patch release (I think it's a strict improvement over the current color scheme).

WIP: https://kimikage.github.io/july-morning-theme/previews/PR1/design-language/

This is also really cool. Do you reckon we could make it part of Documenter's documentation?

fredrikekre pushed a commit that referenced this issue Jul 19, 2021
This will update the definition of basic color variables such as `$red`.
This also tweaks the ANSI colors by deriving from those basic colors.
However, the colors for admonitions etc. are kept as they are, for compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants