Skip to content

Commit

Permalink
Make deploydocs throw if push fails (#1529)
Browse files Browse the repository at this point in the history
  • Loading branch information
mortenpi authored Feb 16, 2021
1 parent f7c7929 commit 57a983f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

- highlight.js has been updated to `v10.5.0`, which also brings various updates to the highlighting of Julia code. Due to the changes in highlight.js, code highlighting will not work on IE11. ([#1503][github-1503])

* ![Enhancement][badge-enhancement] `deploydocs` now throws an error if something goes wrong with the Git invocations used to deploy to `gh-pages`. ([#1529][github-1529])

## Version `v0.26.2`

* ![Enhancement][badge-enhancement] `doctest()` no longer throws an error if cleaning up the temporary directory fails for some reason. ([#1513][github-1513], [#1526][github-1526])
Expand Down Expand Up @@ -753,6 +755,7 @@
[github-1520]: https://github.com/JuliaDocs/Documenter.jl/pull/1520
[github-1526]: https://github.com/JuliaDocs/Documenter.jl/pull/1526
[github-1527]: https://github.com/JuliaDocs/Documenter.jl/pull/1527
[github-1529]: https://github.com/JuliaDocs/Documenter.jl/pull/1529

[julia-38079]: https://github.com/JuliaLang/julia/issues/38079

Expand Down
2 changes: 2 additions & 0 deletions src/Documenter.jl
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,7 @@ function git_push(
catch e
@error "Failed to push:" exception=(e, catch_backtrace())
post_status(deploy_config; repo=repo, type="error")
rethrow(e)
finally
# Remove the unencrypted private key.
isfile(keyfile) && rm(keyfile)
Expand All @@ -676,6 +677,7 @@ function git_push(
catch e
@error "Failed to push:" exception=(e, catch_backtrace())
post_status(deploy_config; repo=repo, type="error")
rethrow(e)
end
end
end
Expand Down

0 comments on commit 57a983f

Please sign in to comment.