Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat for Aqua and stdlibs #341

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Add compat for Aqua and stdlibs #341

merged 1 commit into from
Nov 27, 2023

Conversation

Sbozzolo
Copy link
Contributor

TaylorSeries.jl did not specify a compat for Aqua. Aqua 0.8 introduces some breaking changes, such as renaming test_piracy to test_piracies, leading to broken test if one has a recent version of Aqua in their environment.

I added a compat for Aqua. New versions of Aqua also check for compats for standard libraries (which will be a requirement to publish the package), so I added those as well.

@coveralls
Copy link

coveralls commented Nov 24, 2023

Coverage Status

coverage: 97.207% (+0.2%) from 96.96%
when pulling b0c820b on Sbozzolo:master
into ff1f680 on JuliaDiff:master.

@lbenet
Copy link
Member

lbenet commented Nov 27, 2023

Hi @Sbozzolo, thanks a lot for opening this PR and for the contribution, and sorry for the time to respond to it. Your PR is very very timely. In relation to #339 I've been checking Aqua, so I will leave a few suggestions to add which simply exploit further Aqua. I hope this afternoon I'll send you these suggestions.

Copy link
Member

@lbenet lbenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR. I left one single comment (which actualy touches both files), to include further Aqua checks. Once that is implemented, I will be happy to merge it (and we should probably tag a new (patch?) version.

test/aqua.jl Show resolved Hide resolved
TaylorSeries.jl did not specify a compat for Aqua. Aqua 0.8 introduces
some breaking changes, such as renaming test_piracy to test_piracies,
leading to broken test if one has a recent version of Aqua in their
environment.

I added a compat for Aqua. New versions of Aqua also check for compats
for standard libraries (which will be a requirement to publish the
package), so I added those as well.
@lbenet
Copy link
Member

lbenet commented Nov 27, 2023

Tests pass, so I'm merging.

Thanks a lot @Sbozzolo !!

@lbenet lbenet merged commit 5895948 into JuliaDiff:master Nov 27, 2023
12 checks passed
@PerezHz
Copy link
Contributor

PerezHz commented Nov 28, 2023

(and we should probably tag a new (patch?) version.

I'd be personally in favor of bumping the patch version 😄

@lbenet
Copy link
Member

lbenet commented Nov 29, 2023

Me too... hold me on just a couple of days; I'm addressing #339, and noticed that some ambiguities may occur. (If this takes too long, I'll simply tag the new patch version.)

@lbenet lbenet mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants