Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inference's job much easier by avoiding map #149

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Conversation

ChrisRackauckas
Copy link
Member

@ChrisRackauckas ChrisRackauckas commented Aug 11, 2021

Before:

function lorenz(du,u,p,t)
 du[1] = 10.0(u[2]-u[1])
 du[2] = u[1]*(28.0-u[3]) - u[2]
 du[3] = u[1]*u[2] - (8/3)*u[3]
end

u0 = [1.0;0.0;0.0]
tspan = (0.0,100.0)

using OrdinaryDiffEq, SnoopCompile
prob = ODEProblem(lorenz,u0,tspan)
alg = Rodas5()
tinf = @snoopi_deep solve(prob,alg)

@ChrisRackauckas
Copy link
Member Author

function lorenz(du,u,p,t)
 du[1] = 10.0(u[2]-u[1])
 du[2] = u[1]*(28.0-u[3]) - u[2]
 du[3] = u[1]*u[2] - (8/3)*u[3]
end

u0 = [1.0;0.0;0.0]
tspan = (0.0,100.0)

using OrdinaryDiffEq, SnoopCompile
prob = ODEProblem(lorenz,u0,tspan)
alg = Rodas5(chunk_size = 3)
tinf = @snoopi_deep solve(prob,alg)

down from 16 seconds to 2.5

InferenceTimingNode: 1.310514/2.560714 on Core.Compiler.Timings.ROOT() with 17 direct children

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #149 (73f2018) into master (fb09091) will increase coverage by 0.21%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   83.48%   83.69%   +0.21%     
==========================================
  Files          12       12              
  Lines         666      687      +21     
==========================================
+ Hits          556      575      +19     
- Misses        110      112       +2     
Impacted Files Coverage Δ
src/differentiation/compute_jacobian_ad.jl 94.14% <93.54%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb09091...73f2018. Read the comment docs.

@ChrisRackauckas
Copy link
Member Author

InferenceTimingNode: 1.158426/2.076904 on Core.Compiler.Timings.ROOT() with 9 direct children

With the last commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants