Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In checking method table don't nest testsets #237

Merged
merged 1 commit into from
Jan 21, 2022
Merged

In checking method table don't nest testsets #237

merged 1 commit into from
Jan 21, 2022

Conversation

oxinabox
Copy link
Member

Follow up to #228 now that i tried it for real.

I forgot all passing testsets were show if in same testset as failing one.
Which on real use cases is 1459

Test Summary:             | Pass  Fail  Total
ChainRules                | 1529     1   1530
  test_helpers.jl         |   69           69
  Sensible Constructors   | 1460     1   1461
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    Sensible Constructors |    1            1
    ...
    ```

@codecov-commenter
Copy link

Codecov Report

Merging #237 (ed673f0) into main (a1b0ed0) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   90.71%   90.65%   -0.06%     
==========================================
  Files          12       12              
  Lines         323      321       -2     
==========================================
- Hits          293      291       -2     
  Misses         30       30              
Impacted Files Coverage Δ
src/global_checks.jl 92.00% <100.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b0ed0...ed673f0. Read the comment docs.

@mzgubic
Copy link
Member

mzgubic commented Jan 21, 2022

Hmm, would this not also show up in the ChainRules testset in a similar way?

@oxinabox
Copy link
Member Author

Hmm, would this not also show up in the ChainRules testset in a similar way?

I don't understand.
This had a

for x in methods(...)
    @testset ...
    end
end

(once you inline the method)

@mzgubic
Copy link
Member

mzgubic commented Jan 21, 2022

Oh, of course, makes sense now. it's friday night, i should go eat pizza

@oxinabox oxinabox merged commit b8f4217 into main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants