Implement isapprox for Composites (#75)

* Implement isapprox for Composites * Bump version number * Add a test
JuliaDiff · Nov 30, 2020 · 5076373 · 5076373 · willtebbutt · Nov 30, 2020
1 parent 6f5cd3f
commit 5076373
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "ChainRulesTestUtils"
 uuid = "cdddcdb0-9152-4a09-a978-84456f9df70a"
-version = "0.5.3"
+version = "0.5.4"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

diff --git a/src/isapprox.jl b/src/isapprox.jl
@@ -15,6 +15,13 @@ function Base.isapprox(
 ) where {P <: Tuple}
     return isapprox_vec(d_ad, d_fd; kwargs...)
 end
+
+function Base.isapprox(
+    d_ad::Composite{P, <:NamedTuple{T}}, d_fd::Composite{P, <:NamedTuple{T}}; kwargs...,
+) where {P, T}
+    return isapprox_vec(d_ad, d_fd; kwargs...)
+end
+
+
 # Must be for same primal
 Base.isapprox(d_ad::Composite{P}, d_fd::Composite{Q}; kwargs...) where {P, Q} = false
-
diff --git a/test/isapprox.jl b/test/isapprox.jl
@@ -14,6 +14,9 @@
             # both of these are reasonable diffentials for the `Tuple{Int, Int}` primal
             @test Composite{Tuple{Int, Int}}(1f0, 2f0) ≈ Composite{Tuple{Int, Int}}(1.0, 2.0)
 
+            D = Diagonal(randn(5))
+            @test Composite{typeof(D)}(diag=D.diag) ≈ Composite{typeof(D)}(diag=D.diag)
+
             # But these have different primals so should not be equal
             @test !(Composite{Tuple{Int, Int}}(1.0, 2.0) ≈ Composite{Tuple{Float64, Float64}}(1.0, 2.0))
         end