-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to Documenter 0.25 #200
Conversation
Thanks! Unfortunately this seems to break the custom CSS, including the styling of the "terminology" admonitions. It'd at least be good to fix those of possible |
Oh right, didn't notice that at first! Seems like Documenter changed some stuff around internally. I will see, what I can do. |
This will close #153 Like Nick said this breaks the custom CSS. |
Note also that recent versions of Documenter by default use KaTeX to render equations, which renders faster but does not support as much as MathJax. In particular it breaks the array rules tutorial: https://www.juliadiff.org/ChainRulesCore.jl/previews/PR200/arrays.html. There's an argument to switch the backend back to MathJax, or we can update the tutorial to only use KaTeX supported features. I'm inclined to say we do the former for now and then revisit the latter in another PR if we wish. |
The dark theme doesn't look quite right with our modifications, so I still need to figure out how to fix this. |
Should be good to go now. I have disabled most of our customizations for the dark theme, except for our methodology blocks. If we really want to customize the dark theme as well, we could always do that at a later time. |
|
Ok to merge? |
This deletes our old hacky workaround for PR previews and replaces it by Documenter's own
push_preview
version, that was added in 0.24. Hopefully, we should see something at https://www.juliadiff.org/ChainRulesCore.jl/previews/PR200/.Closes #153