-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fast reductions #2869
Merged
Merged
Add fast reductions #2869
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
b6ca433
add fast reduction for sum
bkamins b58ced8
first approach to summation with missings
bkamins 1e5cb69
improve error message
bkamins 748e609
implement safer reduction
bkamins d6339c0
add conversion
bkamins d1d6354
Update src/abstractdataframe/selection.jl
bkamins 0d90feb
Update src/abstractdataframe/selection.jl
bkamins 8f64633
Update src/abstractdataframe/selection.jl
bkamins 97a98b9
Update src/abstractdataframe/selection.jl
bkamins 5b88db8
Update src/abstractdataframe/selection.jl
bkamins adeb553
better handle sumz
bkamins 59aef38
Merge branch 'bk/fast_sum' of https://github.com/JuliaData/DataFrames…
bkamins b972658
changes after code review
bkamins 9d11641
fix typos
bkamins 7924736
refactor code
bkamins 98c48f2
improve implementation to make it use dispatch
bkamins 54735f6
fix typo
bkamins f1b631c
add length and length with skipmissing
bkamins 4c55191
add mean
bkamins 7f0b152
split fast path to a separate file
bkamins 7390702
add minium, maximum, min and max
bkamins 77a3424
Apply suggestions from code review
bkamins 0dcf6f5
use Base.add_sum + fix @noinline
bkamins 9f56c00
Merge branch 'main' into bk/fast_sum
bkamins 9b91f72
Merge branch 'bk/fast_sum' of https://github.com/JuliaData/DataFrames…
bkamins 618832b
fix implementations
bkamins 36450bc
finished design
bkamins 903e57f
add tests of positional reductions
bkamins 286fca0
added length tests
bkamins 0473cd2
done sum testing
bkamins e06bc32
additional sum tests
bkamins a62b73f
finish mean et al. tests
bkamins e4536c6
add minimum and maximum tests
bkamins 083a07f
Merge branch 'main' into bk/fast_sum
bkamins ba0208e
remove @show
bkamins a39aefd
update tests and docstring
bkamins 1c0022b
fixes of x86 arch and Julia 1.0 problems
bkamins 277bb24
fix 32-bit Julia issue
bkamins a766a92
fix more Julia 1.0.5 errors
bkamins a649925
Apply suggestions from code review
bkamins e53a7a2
improve docs
bkamins cc086d7
Merge branch 'bk/fast_sum' of https://github.com/JuliaData/DataFrames…
bkamins 5680902
fix typo
bkamins cd5acdf
Fix code and add tests for Int32
bkamins 54eed61
additional tests
bkamins 4c46bca
Update src/abstractdataframe/selectionfast.jl
bkamins 39790da
Update docs/src/lib/internals.md
bkamins 0bfbc4a
Merge branch 'main' into bk/fast_sum
bkamins 99d459e
update tests
bkamins 05e6031
add NEWS.md
bkamins bb59dd7
Apply suggestions from code review
bkamins 2fa0e01
0-length selection corner cases handling
bkamins 8c83f36
Merge branch 'bk/fast_sum' of https://github.com/JuliaData/DataFrames…
bkamins 07e47a1
fix Julia 1.0 and nightly
bkamins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,6 +82,7 @@ repeat | |
repeat! | ||
select | ||
select! | ||
table_transformation | ||
transform | ||
transform! | ||
vcat | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
table_transformation
a public facing API? Unclear from these docs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is, see https://github.com/JuliaData/DataFrames.jl/pull/2869/files#diff-83f595e5b8d93541942100bc3cb16d0c244b674bfc1b30bfbe043a4e7a5a1ebeR20