Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement hasproperty #1852

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Implement hasproperty #1852

merged 1 commit into from
Jun 18, 2019

Conversation

nalimilan
Copy link
Member

This is consistent with our definition of getproperty and setproperty!.
It also provides an efficient deprecation for haskey, though it turns out the current deprecation didn't support non-Symbols, contrary to the function it replaces.

@nalimilan
Implement hasproperty
d8165cb 
This is consistent with our definition of getproperty and setproperty!.
It also provides an efficient deprecation for haskey, though it turns out
the current deprecation didn't support non-Symbols, contrary to the function
it replaces.
bkamins
bkamins approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasproperty is OK to have.

However, I think - as noted several times that we should also have hascol function that is exposing haskey of AbstractIndex.

@quinnj
Copy link
Member

quinnj commented Jun 17, 2019

I agree this is fine to have here, but I'd also suggest just putting this in Base.

@nalimilan
Copy link
Member Author

I agree this is fine to have here, but I'd also suggest just putting this in Base.

You mean hascol? hasproperty has just been added in Base, and for now it's in Compat.

@quinnj
Copy link
Member

quinnj commented Jun 17, 2019

Ah, I forgot it got put in! Yes, that's right. Carry on.

@nalimilan nalimilan merged commit b60abe9 into master Jun 18, 2019
@nalimilan nalimilan deleted the nl/hasproperty branch June 18, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nalimilan @quinnj @bkamins