Versioning specificity #1015
Merged
Versioning specificity #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the OS X nightly failure is JuliaLang/julia#17484 and the AppVeyor failure is because Rmath and Windows are mortal enemies. Thanks for doing this, looks good to me. |
|
Rmath on Windows is next on my list, really. |
| @@ -8,7 +8,7 @@ function escapedprint(io::IO, x::Any, escapes::AbstractString) | |||
| print(io, x) | |||
| end | |||
|
|
|||
| @static if VERSION < v"0.5.0-" | |||
| @static if VERSION < v"0.5.0-dev+4354" | |||
There was a problem hiding this comment.
Is this @static macro call needed at the top level?
maximerischard
pushed a commit
to maximerischard/DataFrames.jl
that referenced
this pull request
Sep 28, 2016
* Compat minimum version is 0.8.0 for show/writemime and unsafe_string * Be specific about print_escaped renaming for the sake of bisecting ref JuliaLang/julia#16603 * Remove probably-unnecessary at-static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.