Skip to content

Commit

Permalink
remove type specifications to simplify deprecations
Browse files Browse the repository at this point in the history
  • Loading branch information
bkamins committed Oct 1, 2020
1 parent 663eb0f commit 3a45426
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/deprecated.jl
Original file line number Diff line number Diff line change
Expand Up @@ -112,17 +112,17 @@ end
copycols::Bool=true) where {N} DataFrame(collect(columns), collect(cnames);
makeunique=makeunique, copycols=copycols)
@deprecate DataFrame(columns::NTuple{N, AbstractVector}, cnames::NTuple{N, AbstractString}; makeunique::Bool=false,
copycols::Bool=true) where {N} DataFrame(collect(AbstractVector, columns), [Symbol(c) for c in cnames];
copycols::Bool=true) where {N} DataFrame(collect(columns), [Symbol(c) for c in cnames];
makeunique=makeunique, copycols=copycols)
@deprecate DataFrame(columns::NTuple{N, AbstractVector};
copycols::Bool=true) where {N} DataFrame(collect(AbstractVector, columns),
gennames(length(columns)), copycols=copycols)
copycols::Bool=true) where {N} DataFrame(collect(columns),
Symbol.(:x, 1:length(columns)), copycols=copycols)
@deprecate DataFrame(columns::AbstractMatrix, cnames::AbstractVector{Symbol} = gennames(size(columns, 2));
makeunique::Bool=false) DataFrame(AbstractVector[columns[:, i] for i in 1:size(columns, 2)],
makeunique::Bool=false) DataFrame([columns[:, i] for i in 1:size(columns, 2)],
cnames; makeunique=makeunique, copycols=false)

@deprecate DataFrame(columns::AbstractMatrix, cnames::AbstractVector{<:AbstractString};
makeunique::Bool=false) DataFrame(AbstractVector[columns[:, i] for i in 1:size(columns, 2)],
makeunique::Bool=false) DataFrame([columns[:, i] for i in 1:size(columns, 2)],
Symbol.(cnames); makeunique=makeunique, copycols=false)

function DataFrame(column_eltypes::AbstractVector{T}, cnames::AbstractVector{Symbol},
Expand Down

0 comments on commit 3a45426

Please sign in to comment.