Compat fixes for v0.5 and v0.6 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookay
reviewed
Apr 11, 2017
test/util.jl
Outdated
| @@ -1,4 +1,5 @@ | |||
| using DSP, Base.Test, Compat | |||
| using SpecialFunctions | |||
There was a problem hiding this comment.
besseli has used in the function kaiser at src/windows.jl,
so it could be import SpecialFunctions.besseli to the module Windows.
should be no warnings in compling DSP
hadn't look deeper yet but it seems like `roots` breaks
|
bump |
|
Thanks |
|
Could anybody tag a new release? Tests failing with v0.5 and v0.6 (http://pkg.julialang.org/?pkg=DSP#DSP). |
|
I'm working on it. It looks like the test failures you experienced were caused by 0.0 being not identical to -0.0 in our code, but it appears to work fine on Polynomials master branch. A new version should be published soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this changes, it should be no warnings compiling DSP.jl on v0.5 and v0.6 (master). Some notes:
A{T1,T2}(a, b) where {T1,T2}) cannot be parsed with v0.5, I had to use deprecated call overloading syntax(::Type{A{T1,T2}}{T1,T2}(a,b)instead (ref: Inner constructor JuliaLang/Compat.jl#332). This should be updated once we can drop v0.5.