remove automatic field propagation from balance_statespace
#863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason is that many abstract statespace types have fields that are affected by the balancing, and the automatic forwarding of those fields without application of the balancing led to incorrect answers. The proper way of handling this is for each type to implement their own method of `balance_statespace` if the additional fields are required.
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage 92.72% 92.72%
=======================================
Files 5 5
Lines 330 330
=======================================
Hits 306 306
Misses 24 24 |
|
This is an automated message.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason is that many abstract statespace types have fields that are affected by the balancing, and the automatic forwarding of those fields without application of the balancing led to incorrect answers. The proper way of handling this is for each type to implement their own method of
balance_statespaceif the additional fields are required.