Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove instance with h where it should be Ts #832

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

albheim
Copy link
Member

@albheim albheim commented Apr 28, 2023

Looking through some old issues I saw #447 which seemed mostly resolved, though there was this one random occurrence of h which was not even referenced in the function body, so it felt like it should be removed since it could accidentally lead to bugs with silently accepting the h and returning something other than intended.

Looking through some old issues I saw #447 which seemed mostly resolved, though there was this one random occurrence of `h` which was not even referenced in the function body, so it felt like it should be removed since it could accidentally lead to bugs with silently accepting the `h` and returning something other than intended.
@albheim albheim linked an issue Apr 28, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #832 (b2dff5d) into master (1e1512e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           4        4           
  Lines         315      315           
=======================================
  Hits          306      306           
  Misses          9        9           

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.047 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.007 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@baggepinnen baggepinnen merged commit a5db7d9 into master Apr 28, 2023
@baggepinnen baggepinnen deleted the albheim-patch-1 branch April 28, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-positive Ts for continuous types
3 participants