Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn more against high-order transfer functions #800

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Conversation

baggepinnen
Copy link
Member

This problem keeps hitting people in one form or another. This PR adds a warning when a high-order tf is created if it uses coefficients of floats that are no more precise than Float64. It also extends the already present section in the docs describing the problem with an illustrative example

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #800 (b064857) into master (07e0354) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #800   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           4        4           
  Lines         315      315           
=======================================
  Hits          306      306           
  Misses          9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 11/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.011 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.006 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
⚠️ 0.028 Reference New
❌ 0.06 Reference New
✔️ 0.0 Reference New
⚠️ 0.017 Reference New

@baggepinnen baggepinnen merged commit dc1d477 into master Feb 1, 2023
@baggepinnen baggepinnen deleted the highorder branch February 1, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants