Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options and more docstring to loopshapingPI #745

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Conversation

baggepinnen
Copy link
Member

  • Make the plot appear similar to the one produced by loopshapingPID
  • Add option to design with filter.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 9/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.034 Reference New
❌ 0.059 Reference New
✔️ 0.0 Reference New
✔️ 0.01 Reference New

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #745 (f03fdde) into master (e9460ef) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   91.88%   91.93%   +0.04%     
==========================================
  Files          37       37              
  Lines        3995     4003       +8     
==========================================
+ Hits         3671     3680       +9     
+ Misses        324      323       -1     
Impacted Files Coverage Δ
src/pid_design.jl 94.68% <100.00%> (+0.14%) ⬆️
src/analysis.jl 96.98% <0.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@baggepinnen baggepinnen merged commit 8bb2312 into master Sep 7, 2022
@baggepinnen baggepinnen deleted the lsPI_options branch September 7, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants