Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set force_dtmin by default #690

Merged
merged 2 commits into from
Jun 9, 2022
Merged

set force_dtmin by default #690

merged 2 commits into from
Jun 9, 2022

Conversation

baggepinnen
Copy link
Member

DelayDiffEq with high-order solvers sometimes struggle to simulate step responses, this PR adjusts a default value to the solver to accept that the dt becomes small around discontinuities in the input

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 8/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
❌ 0.048 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
❌ 0.043 Reference New
❌ 0.046 Reference New
✔️ 0.01 Reference New

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #690 (8f94ef7) into master (3889c07) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files          34       34           
  Lines        3579     3579           
=======================================
  Hits         3130     3130           
  Misses        449      449           
Impacted Files Coverage Δ
src/delay_systems.jl 88.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3889c07...8f94ef7. Read the comment docs.

@baggepinnen baggepinnen merged commit fb20e95 into master Jun 9, 2022
@baggepinnen baggepinnen deleted the robust_delaysim branch June 9, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants