-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argument to nyquistplot for critical point #688
Conversation
Considering a Nyquist plot for the return difference F = 1 + L, we should mark the origin as the critical point instead of -1. Similarly, it allows plotting of the determinant of the return difference for a MIMO system, as we necessarily need to test encirclements of the origin.
Is it common to have the system 1+L instead of L, or is it nicer to plot for some reason? Couldn't you just plot F-1 instead if you know your system is on that form? Not saying it isn't a valid request, just want to understand the need since I have not encountered this myself and I don't immediately see any real benefit compared to just sending in F-1. |
Maybe a good option would be to let the argument control the position of the point, so that
would be the default and
would mark the origin? |
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 34 34
Lines 3579 3579
=======================================
Hits 3130 3130
Misses 449 449
Continue to review full report at Codecov.
|
@albheim For a generalized Nyquist stability criterion, you plot I have added the proposed change. |
Cool, thanks! The argument should probably be reflected in the docstring as well, and then we're good to merge |
Thanks for your contribution, a new release will be out soon :) |
Considering a Nyquist plot for the return difference F = 1 + L, we should mark the origin as the critical point instead of -1. Similarly, it allows plotting of the determinant of the return difference for a MIMO system, as we necessarily need to test encirclements of the origin. Default remains -1 as the critical point.