deactivate broken features from bodeplot #667
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deactivates a lot of the "smart features" in the
bodeplot
since they are broken in too many cases.The biggest problem is that if
bodeplot
is invoked twice, the second invocation overrides everything that was set during the first invocation. This causes x/y-ticks to be garbage and overrides user set titles and labels. Also, the automatic labelG_1(s)
does not increase the subscript number unless bodeplot is invoked once only, causing multiple systems to get the same label.I have tried for a while to fix the problems, but it requires making use of a lot of internals and I didn't manage to get a robust solution. If anyone wants to commit to implementing and maintaining a really solid and robust solution that works for all backends, I'd be up for that, otherwise I say we ditch all the broken code.