Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce allocations in lsim #651

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

baggepinnen
Copy link
Member

Benchmark

sys = ssrand(5,5,10, Ts=1);
u = randn(5,10000);
@btime lsim($sys, $u);

# 812.612 μs (11 allocations: 1.98 MiB) # before
# 690.747 μs (7 allocations: 1.22 MiB)  # after

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #651 (c636fb3) into master (4feb58d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   86.62%   86.63%   +0.01%     
==========================================
  Files          31       31              
  Lines        3311     3315       +4     
==========================================
+ Hits         2868     2872       +4     
  Misses        443      443              
Impacted Files Coverage Δ
src/timeresp.jl 90.00% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4feb58d...c636fb3. Read the comment docs.

@baggepinnen baggepinnen merged commit 050eb81 into JuliaControl:master Feb 21, 2022
@baggepinnen baggepinnen deleted the lsimallocs branch February 21, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant