Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and test type stability in system concatenation #643

Merged
merged 16 commits into from
Feb 19, 2022
Merged

Conversation

baggepinnen
Copy link
Member

Also reduces some allocations

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 9/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.003 Reference New
✔️ 0.003 Reference New
✔️ 0.001 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
❌ 0.042 Reference New
✔️ 0.006 Reference New
✔️ 0.011 Reference New

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #643 (cc4814e) into master (4c4c205) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #643   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files          31       31           
  Lines        3253     3253           
=======================================
  Hits         2822     2822           
  Misses        431      431           
Impacted Files Coverage Δ
src/connections.jl 92.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4c205...cc4814e. Read the comment docs.

@baggepinnen baggepinnen merged commit c2649b4 into master Feb 19, 2022
@baggepinnen baggepinnen deleted the typestabconn branch February 19, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants