Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ny,nu fields from TransferFunction #624

Merged
merged 2 commits into from
Jan 29, 2022
Merged

remove ny,nu fields from TransferFunction #624

merged 2 commits into from
Jan 29, 2022

Conversation

baggepinnen
Copy link
Member

Closes #399

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 9/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.003 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
❌ 0.042 Reference New
✔️ 0.006 Reference New
✔️ 0.011 Reference New

@baggepinnen baggepinnen reopened this Jan 28, 2022
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 9/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.003 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
❌ 0.042 Reference New
✔️ 0.006 Reference New
✔️ 0.011 Reference New

@albheim
Copy link
Member

albheim commented Jan 29, 2022

Realised I approved without checking if it passed... But the changes seem reasonable to me so as long as the expected tests pass I think it is all good :)

@baggepinnen baggepinnen force-pushed the TF_fields branch 2 times, most recently from 4cf4204 to d2532dc Compare January 29, 2022 13:59
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #624 (54d5df8) into master (9455a54) will decrease coverage by 0.11%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   86.75%   86.63%   -0.12%     
==========================================
  Files          31       31              
  Lines        3253     3255       +2     
==========================================
- Hits         2822     2820       -2     
- Misses        431      435       +4     
Impacted Files Coverage Δ
src/types/Lti.jl 55.55% <ø> (-4.45%) ⬇️
src/types/TransferFunction.jl 89.56% <82.35%> (-1.70%) ⬇️
src/types/PartionedStateSpace.jl 94.23% <100.00%> (+0.11%) ⬆️
src/types/StateSpace.jl 87.44% <100.00%> (+0.10%) ⬆️
src/connections.jl 92.68% <0.00%> (-0.58%) ⬇️
src/types/conversion.jl 97.03% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9455a54...54d5df8. Read the comment docs.

@baggepinnen baggepinnen merged commit 3daccd9 into master Jan 29, 2022
@baggepinnen baggepinnen deleted the TF_fields branch January 29, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add constructors with nu, ny, nx for easy rebuilding
3 participants