Fix some problems for comparisons between tfs #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albheim
commented
Jan 28, 2022
|
This is an automated message.
|
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
- Coverage 86.80% 86.77% -0.03%
==========================================
Files 31 31
Lines 3243 3260 +17
==========================================
+ Hits 2815 2829 +14
- Misses 428 431 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests added here would have returned incorrectly before, thanks to incorrect indexing into the polynomials.
Fix indexing, add tests for the previous error and fix new test error that was previously hidden by allowing approximate comparison between polynomials of different sizes.