Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for lft, issue #577 #578

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

olof3
Copy link
Contributor

@olof3 olof3 commented Dec 19, 2021

The indices for what to connect to the Delta block were completely messed up.

Closes #577.

@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #578 (c79d757) into master (ad1306c) will decrease coverage by 0.66%.
The diff coverage is 100.00%.

❗ Current head c79d757 differs from pull request most recent head ce44332. Consider uploading reports for the commit ce44332 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
- Coverage   84.99%   84.33%   -0.67%     
==========================================
  Files          31       31              
  Lines        3073     3109      +36     
==========================================
+ Hits         2612     2622      +10     
- Misses        461      487      +26     
Impacted Files Coverage Δ
src/connections.jl 93.25% <100.00%> (+0.03%) ⬆️
src/matrix_comps.jl 82.46% <0.00%> (-5.56%) ⬇️
src/types/StateSpace.jl 88.42% <0.00%> (-4.00%) ⬇️
src/delay_systems.jl 88.75% <0.00%> (-0.93%) ⬇️
src/types/TransferFunction.jl 91.20% <0.00%> (-0.93%) ⬇️
src/ControlSystems.jl 100.00% <0.00%> (ø)
src/plotting.jl 76.47% <0.00%> (+0.05%) ⬆️
src/types/conversion.jl 96.29% <0.00%> (+0.08%) ⬆️
src/types/zpk.jl 97.43% <0.00%> (+0.21%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e43220...ce44332. Read the comment docs.

@baggepinnen baggepinnen merged commit 74f3ebf into JuliaControl:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LFT doesn't give results as in K. Zhou, J. Doyle
2 participants