Modify LQG speed control of DC motor example #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace logspace function because it is no longer in Julia - add dot operator to Nbar evaluation - gather all plots inside script into one plot and other cosmetic changes
baggepinnen
approved these changes
Jan 3, 2021
|
Hello, thank you reviewing and approving. |
|
No, our problem is that we currently don't have working CI. There's a PR that activates github actions to run our tests, but it has nog been merged yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MethodError: no method matching /(::Float64, ::Array{Float64,2})is produced.f1, f2, f3, f4and plot all at once at the end of the script. Otherwise, only the last plot is shown if running from the terminal.