-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove matrix size from StateSpace types #411
Conversation
Looks good, great to get rid of those fields. There were a lot of other fixes in #410, what about those? |
I accidentally included tons of unrelated commits from my working branch. They might make their way into master eventually, but I have a few PRs waiting to be merged before I can submit the rest of the changes. |
Looked like there was a lot of useful stuff there :) |
Hmm, the failing test only fails on julia v1.5, not on julia v1.0 or nightly |
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
- Coverage 82.40% 77.09% -5.31%
==========================================
Files 31 31
Lines 2824 2855 +31
==========================================
- Hits 2327 2201 -126
- Misses 497 654 +157
Continue to review full report at Codecov.
|
Solves #399 and supersedes #400