Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dlqr method for StateSpace input #406

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

adrhill
Copy link
Contributor

@adrhill adrhill commented Dec 4, 2020

This method was already documented in the dlqr docstring but not implemented:

"""`dlqr(A, B, Q, R)`, `dlqr(sys, Q, R)`

and add test in LQR testset
Copy link
Member

@baggepinnen baggepinnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Later on we can probably remove the d versions of these methods since now the Continuous/Discrete is part of the type and this can be solved with dispatch rather than separate functions.

@baggepinnen baggepinnen reopened this Jan 16, 2021
@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #406 (f976876) into master (6c54a25) will decrease coverage by 5.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   82.40%   77.12%   -5.28%     
==========================================
  Files          31       31              
  Lines        2824     2837      +13     
==========================================
- Hits         2327     2188     -139     
- Misses        497      649     +152     
Impacted Files Coverage Δ
src/synthesis.jl 67.64% <100.00%> (+2.02%) ⬆️
src/pid_design.jl 32.57% <0.00%> (-45.38%) ⬇️
src/discrete.jl 40.54% <0.00%> (-43.72%) ⬇️
src/types/SisoTf.jl 25.00% <0.00%> (-25.00%) ⬇️
src/types/SisoTfTypes/SisoZpk.jl 60.00% <0.00%> (-21.11%) ⬇️
src/freqresp.jl 88.00% <0.00%> (-3.90%) ⬇️
src/utilities.jl 80.21% <0.00%> (-2.58%) ⬇️
src/types/Lti.jl 54.76% <0.00%> (-2.39%) ⬇️
src/types/SisoTfTypes/SisoRational.jl 72.58% <0.00%> (-1.62%) ⬇️
src/types/StateSpace.jl 89.28% <0.00%> (-1.20%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c54a25...f976876. Read the comment docs.

@baggepinnen baggepinnen merged commit 59dce66 into JuliaControl:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants