Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specification of Tf instead of time vector in lsim #403

Merged
merged 3 commits into from
Jan 17, 2021

Conversation

baggepinnen
Copy link
Member

No description provided.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. No changes were detected.

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #403 (4be70c1) into master (2fd813d) will decrease coverage by 5.37%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   82.40%   77.02%   -5.38%     
==========================================
  Files          31       31              
  Lines        2824     2838      +14     
==========================================
- Hits         2327     2186     -141     
- Misses        497      652     +155     
Impacted Files Coverage Δ
src/timeresp.jl 91.33% <0.00%> (-2.21%) ⬇️
src/pid_design.jl 32.57% <0.00%> (-45.38%) ⬇️
src/discrete.jl 40.54% <0.00%> (-43.72%) ⬇️
src/types/SisoTf.jl 25.00% <0.00%> (-25.00%) ⬇️
src/types/SisoTfTypes/SisoZpk.jl 60.00% <0.00%> (-21.11%) ⬇️
src/freqresp.jl 88.00% <0.00%> (-3.90%) ⬇️
src/utilities.jl 80.21% <0.00%> (-2.58%) ⬇️
src/types/Lti.jl 54.76% <0.00%> (-2.39%) ⬇️
src/types/SisoTfTypes/SisoRational.jl 72.58% <0.00%> (-1.62%) ⬇️
src/types/StateSpace.jl 89.28% <0.00%> (-1.20%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd813d...4be70c1. Read the comment docs.

@mfalt
Copy link
Member

mfalt commented Nov 28, 2020

What is the warning codecov complains about here? We should have at least one test for this case.

I guess Julia is still able to infer the type of t here?

Edit: Good catch, I thought we already allowed this. But maybe it's neater to use multiple dispatch for this?

@mfalt
Copy link
Member

mfalt commented Nov 28, 2020

Also, sys.Ts is not what we want to use for time vector, at least not for continuous systems. _default_time_vector(sys, t) is probably right.

@baggepinnen baggepinnen reopened this Jan 16, 2021
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. No changes were detected.

@baggepinnen baggepinnen merged commit 9ffced5 into master Jan 17, 2021
@baggepinnen baggepinnen deleted the baggepinnen-patch-1 branch January 17, 2021 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants