Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manifest.toml to .gitignore #389

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Add Manifest.toml to .gitignore #389

merged 1 commit into from
Nov 4, 2020

Conversation

albheim
Copy link
Member

@albheim albheim commented Nov 4, 2020

I just felt that either the Manifest.toml should be checked in to the repo or it should be in the .gitignore file, I don't really see any reason why it should not be one of those two cases.

I found a short discourse thread on this here where there are some mixed opinions, but it seems that most people agree that for a package it is not really necessary. Someone also brings up the point that it might actually be good to have developers have slightly different versions of dependencies to have our package tested over a wider variety of environments, but also brings up the value of having a history of working Manifests stored in the repo.

I'm leaning more towards adding it to the ignore (hence the PR) but mostly feel that just doing either is nicer than having untracked unignored generated files in the repo.

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. No changes were detected.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #389 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files          31       31           
  Lines        2824     2824           
=======================================
  Hits         2327     2327           
  Misses        497      497           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311013e...90a86f6. Read the comment docs.

@baggepinnen baggepinnen merged commit 4ee4a27 into master Nov 4, 2020
@baggepinnen baggepinnen deleted the update_gitignore branch November 4, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants