Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in getLogTicks #375

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Bugfix in getLogTicks #375

merged 1 commit into from
Oct 21, 2020

Conversation

baggepinnen
Copy link
Member

If plotting a bodeplot in a figure that already contains data that was plotted manually, it could happen that mix == 0 which cause an InexactError: trunc(Int64, Inf). This PR just introduces a safeguard against thatn

If plotting a bodeplot in a figure that already contains data that was plotted manually, it could happen that `mix == 0` which cause an `InexactError: trunc(Int64, Inf)`. This PR just introduces a safeguard against thatn
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. No changes were detected.

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files          31       31           
  Lines        2822     2822           
=======================================
  Hits         2326     2326           
  Misses        496      496           
Impacted Files Coverage Δ
src/plotting.jl 78.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094e3cc...a7bf742. Read the comment docs.

@baggepinnen baggepinnen merged commit 9e88577 into master Oct 21, 2020
@baggepinnen baggepinnen deleted the baggepinnen-patch-1 branch October 21, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants