Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choose more sensible yticks for Phasediagram in Bodeplot (unconditionaly) #272

Merged
merged 3 commits into from
Jan 17, 2021

Conversation

freemin7
Copy link
Contributor

This commit makes the yticks of the phase diagram in the BodePlot a multiple of 45° and 90°.
Somehow a previous pull request (changing the documentation of bodeplot to mention setPlotScale(str)) ended being included. No idea how that happened. This pull request was already accepted though.
This behavior has currently no switch, since 45° or 90° are always sensible unless you are dealing with exotic transfer functions (i think it was fractions powers of s).

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 57.242% when pulling 77607aa on freemin7:master into bfadc8f on JuliaControl:master.

@coveralls
Copy link

coveralls commented Mar 17, 2020

Coverage Status

Coverage decreased (-0.2%) to 57.514% when pulling 8c3a0a9 on freemin7:master into c5efbcb on JuliaControl:master.

@freemin7
Copy link
Contributor Author

Is this merged?
I am kind of confused and this one of my first pull requests, so... it would be great if you could give feedback whether it is merged and whether there is something wrong with the code.

@baggepinnen
Copy link
Member

Looks good to me. The one who merges should run the plot reference app as well. Have you tested it manually that it produces nice looking plots when several systems are plotted in the same plot? Especially if the different systems have phase curves spanning different intervals of the phase axis.

@freemin7
Copy link
Contributor Author

I think i tested it.
Both the case where it spans less than a full rotation and the the case where is does span more than a full rotation. I was happy with the results. But that feels like forever ago. I can't believe it was just 3 days. My god does Corona make me productive.

@mfalt mfalt closed this Mar 31, 2020
@mfalt mfalt reopened this Mar 31, 2020
@baggepinnen baggepinnen reopened this Jan 17, 2021
@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@c5efbcb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #272   +/-   ##
=========================================
  Coverage          ?   77.09%           
=========================================
  Files             ?       31           
  Lines             ?     2851           
  Branches          ?        0           
=========================================
  Hits              ?     2198           
  Misses            ?      653           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5efbcb...8c3a0a9. Read the comment docs.

@baggepinnen baggepinnen merged commit c652a2d into JuliaControl:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants