Release 0.5.4 option2 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added julia 1.2 to test matrix
mfalt
commented
Nov 4, 2019
1 similar comment
Closed
|
Set Polynomials to use new print interface (>=0.6.0). If tests pass I think we should pull this. @baggepinnen ? @olof3 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #234 but without sorting of eigenvalues. The sorting therefore defaults to that of the solver, which in LAPACK keeps complex conjugated poles together, and the same seems to be true for GenericLinearAlgebra.
This would potentially be breaking for users in Julia 1.2 if they expect a specific ordering, although no ordering was documented.
The same is true for users of Julia < 1.2 with the other alternative.I had to copy and editrootsfromPolynomials.jlsince it orders by default.