Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pidplots for cases where plot type is not :controller #227

Merged
merged 3 commits into from
Oct 30, 2019

Conversation

non-Jedi
Copy link
Contributor

Fix #226

Logic checking for :nichols was removed as nothing was being done with nichols_ in current code.

@coveralls
Copy link

coveralls commented Aug 27, 2019

Coverage Status

Coverage decreased (-5.009%) to 53.004% when pulling c3b25ef on non-Jedi:patch1 into 9f3bd5d on JuliaControl:master.

@mfalt
Copy link
Member

mfalt commented Oct 29, 2019

I think this looks good, can we pull this @baggepinnen ?

@mfalt mfalt added this to the 0.5.4 milestone Oct 29, 2019
@baggepinnen
Copy link
Member

I made some further changes so that the example in the docs works as intended. It produces all plots well on my local machine.

@mfalt mfalt merged commit e2596cb into JuliaControl:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pidplots returns nothing unless :controller in args
4 participants