Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defenition of dlqr for vector case #223

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Remove defenition of dlqr for vector case #223

merged 4 commits into from
Oct 31, 2019

Conversation

mfalt
Copy link
Member

@mfalt mfalt commented Jun 11, 2019

It seems completely unnessesary, i.e the original definition seems to work for vectors already?

@mfalt
Remove defenition of dlqr for vector case
5cfae8c 
It seems completely unnessesary?
@mfalt
Copy link
Member Author

mfalt commented Jun 11, 2019

We should probably add a simple test and maybe look into why 7df41ef said this was a bug. Maybe because of old julia version?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 58.019% when pulling 5cfae8c on mfalt-patch-2 into 2faa4b9 on master.

@coveralls
Copy link

coveralls commented Jun 11, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-5.1%) to 53.113% when pulling f9bbb3e on mfalt-patch-2 into 1a38971 on master.

@baggepinnen
Copy link
Member

This was perhaps legacy from before transposes were taken seriously ? :P

@mfalt mfalt added this to the 0.5.4 milestone Oct 29, 2019
@mfalt mfalt merged commit 1e113ca into master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mfalt @coveralls @baggepinnen