fix IO, add test for IO

all tests  pass :) :) :)

.gitignore

@@ -1,3 +1,4 @@
+*.nc
 Manifest.toml
 ################################################################################
 #                          DrWatson Project Structure                          #

src/core/nc_io.jl

@@ -249,21 +249,25 @@ function climarrays_to_nc(file::String, X::ClimArray; globalattr = Dict())
 end
 function climarrays_to_nc(file::String, Xs; globalattr = Dict())
     ds = NCDataset(file, "c"; attrib = globalattr)
-    for (i, fieldname) in enumerate(Xs)
-        println("processing variable $fieldname...")
-        W = climarray_from_xarray(xa, fieldname)
-        println("converting to CERES format...")
-        X = to_CERES_latitude(W)
-        println("writing dimensions...")
-        add_dims_to_ncfile!(ds, dims(X))
-        println("writing the CF-variable...")
-        attrib = X.attrib
-        dnames = dim_to_commonname.(dims(X))
-        data = Array(X)
-        @show (fieldname, summary(data), dnames)
-        defVar(ds, fieldname, data, (dnames...,); attrib)
-    end
-    close(ds)
+    # NCDataset("file.nc", "c"; attrib = globalattr) do ds
+        for (i, X) in enumerate(Xs)
+            n = string(X.name)
+            if n == ""
+                n = "x$i"
+                @warn "$i-th ClimArray has no name, naming it $(n) instead."
+            end
+            println("processing variable $(n)...")
+            println("writing dimensions...")
+            add_dims_to_ncfile!(ds, dims(X))
+            println("writing the CF-variable...")
+            attrib = X.attrib
+            isnothing(attrib) && (attrib = Dict())
+            dnames = dim_to_commonname.(dims(X))
+            data = Array(X)
+            defVar(ds, n, data, (dnames...,); attrib)
+        end
+        close(ds)
+    # end
 end
 
 function add_dims_to_ncfile!(ds::NCDatasets.AbstractDataset, dimensions::Tuple)

test/runtests.jl

@@ -1,9 +1,10 @@
 using ClimateBase, Test, Dates
 using Statistics
-
 Time = ClimateBase.Time
+cd(@__DIR__)
 
 # TODO: Further test spatial averaging by making one hemisphere 1 and other 0
+# TODO: Test downloaded .nc file
 
 # Create the artificial dimensional array A that will be used in tests
 function monthly_insolation(t::TimeType, args...)
@@ -31,8 +32,8 @@ for i in 1:length(lats)
     end
 end
 
-A = ClimArray(A, d; name = "lon-variation")
-B = ClimArray(B, d; name = "lon-constant")
+A = ClimArray(A, d; name = "insolation")
+B = ClimArray(B, d; attrib = Dict("a" => 2))
 
 # %%
 
@@ -183,3 +184,21 @@ end
         @test y[j] < y[j-1]
     end
 end
+
+@testset "NetCDF file IO" begin
+    globat = Dict("history" => "test")
+    climarrays_to_nc("test.nc", (A, B); globalattr = globat)
+    Aloaded = ClimArray("test.nc", "insolation")
+    Bloaded = ClimArray("test.nc", "x2")
+
+    @test A.data == Aloaded.data
+    @test dims(Aloaded, Lon).metadata["units"] == "degrees_east"
+    @test B.data == Bloaded.data
+    @test string(Bloaded.name) == "x2"
+    @test dims(Bloaded, Time).metadata["standard_name"] == "time"
+
+    ds = NCDataset("test.nc")
+    @test ds.attrib["history"] == "test"
+    close(ds)
+    rm("test.nc")
+end