Skip to content

Commit

Permalink
Fix a gitignore bug
Browse files Browse the repository at this point in the history
This only came up when you generate more than one package in the same
Julia session. The mutating `append!` function was adding stuff to the
global variable that the coverage plugins were using for their
gitignores. The new `vcat` is non-mutating.
  • Loading branch information
christopher-dG committed Nov 10, 2019
1 parent 08864b3 commit 8d562d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/plugins/git.jl
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ end

# Create the .gitignore.
function hook(p::Git, t::Template, pkg_dir::AbstractString)
ignore = mapreduce(gitignore, append!, t.plugins)
ignore = mapreduce(gitignore, vcat, t.plugins)
# Only ignore manifests at the repo root.
p.manifest || "Manifest.toml" in ignore || push!(ignore, "/Manifest.toml")
unique!(sort!(ignore))
Expand Down

0 comments on commit 8d562d2

Please sign in to comment.