Skip to content
This repository has been archived by the owner on Jun 1, 2021. It is now read-only.

Remove erroneous SparseVector early exit #5

Merged
merged 1 commit into from
Dec 19, 2015

Conversation

mbauman
Copy link
Contributor

@mbauman mbauman commented Dec 18, 2015

There is an optimization available here, but this isn't quite it. Ref JuliaLang/julia#14442.

There is an optimization available here, but this isn't quite it. Ref JuliaLang/julia#14442.
@tkelman
Copy link
Contributor

tkelman commented Dec 19, 2015

Thanks. Do you need/want an invite to this org?

@mbauman
Copy link
Contributor Author

mbauman commented Dec 19, 2015

I'm not currently an org member, but I won't be doing any significant work here in the near future, so it's not a big deal. This was simple enough that I could do it in a few minutes.

That said, it'd probably be good to do a little maintenance on this package if folks are using it (I'm not). If it hasn't happened already, this should be deprecated/capped at 0.4. It'd also be great to port my additional commits from JuliaLang/julia#13440 so this matches what ended up in 0.5.

tkelman added a commit that referenced this pull request Dec 19, 2015
Remove erroneous SparseVector early exit
@tkelman tkelman merged commit fa85259 into JuliaAttic:master Dec 19, 2015
@tkelman
Copy link
Contributor

tkelman commented Dec 19, 2015

As I said over in the julia pr, capping it to 0.4 would cause issues for packages that want to use this on 0.4 and the base version on 0.5, unless we branch this package into an 0.4 version and an empty 0.5 stub. That might be the right approach for whoever wants to put in the work.

@mbauman mbauman deleted the mb/14046 branch December 19, 2015 19:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants