Use Documenter 0.25 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some docs issues, but the upgrade to 0.25 looks smooth. @jagot did you figure out if we need MathJax (in other repos), or whether KaTeX is sufficient? |
|
KaTeX is not sufficient in other repos (don't remember exactly, but I think I could not get eqrefs and such things to work), so I think our conclusion was to use MathJax everywhere, to be consistent. What are the "docs issues"? |
|
Alright, I'll change this over to MathJax then before we merge.
Doctests not passing, |
Scratch that, it already is using MathJax 😆 So I'd say this is good to go. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Documenter to the upcoming 0.24 (currently pinned to the
mp/katjaxbranch withdocs/Manifest.toml).The LaTeX definitions can now be done in
make.jl(JuliaDocs/Documenter.jl#1097), so no need to load thelatex.js(which was a bit unreliable, since we were actually loading and configuring MathJax twice).Here is a demo: https://mortenpi.eu/gsoc2019-mockups/bulma/v14/AtomicLevels/
Once merged, will fix #45.