Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing data type (UInt64/Culonglong) #193

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Add missing data type (UInt64/Culonglong) #193

merged 3 commits into from
Apr 27, 2024

Conversation

Heptazhou
Copy link
Contributor

@Heptazhou Heptazhou commented Nov 29, 2023 •
edited
Loading

CFITSIO definitions for reference:
https://heasarc.gsfc.nasa.gov/docs/software/fitsio/c/c_user/node20.html

Example file to reproduce error:
https://data.sdss.org/sas/dr18/spectro/sdss/redux/v5_13_2/spectra/lite/3650/spec-3650-55244-0001.fits

MWE/MRE:

using FITSIO
fits = FITS("spec-3650-55244-0001.fits")
hdu = fits["SPALL"]
read(hdu, "SPECOBJID")

This pr with JuliaAstro/CFITSIO.jl#22 will fix error(s) including:

  • KeyError: key 80 not found
  • MethodError: no method matching cfitsio_typecode(::Type{UInt64})

@Heptazhou Heptazhou mentioned this pull request Nov 29, 2023
Merged
@Heptazhou Heptazhou marked this pull request as ready for review November 29, 2023 20:56
mileslucas
mileslucas approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@mileslucas mileslucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, perfectly done.

@mileslucas mileslucas merged commit 0ea99f4 into JuliaAstro:master Apr 27, 2024
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mileslucas mileslucas mileslucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Heptazhou @mileslucas