Test last convert method #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 90.83% 90.79% -0.04%
==========================================
Files 36 36
Lines 2663 2663
==========================================
- Hits 2419 2418 -1
- Misses 244 245 +1
Continue to review full report at Codecov.
|
mschauer
reviewed
Aug 10, 2017
test/core.jl
Outdated
| @@ -135,4 +135,6 @@ | |||
| @test Tuple{2, 3, 5} != StaticArrays.Size{(2, 3, 4)} | |||
| @test StaticArrays.Size{(2, 3, 4)} != Tuple{2, 3, 5} | |||
| @test StaticArrays.check_length(2) == nothing | |||
|
|
|||
| @test convert(Tuple, @SVector [1]) == (1,) | |||
There was a problem hiding this comment.
Better, @test convert(Tuple, @SVector [2]) === (2,)
because e.g.
julia> Size(@SVector [1]) == (1,)
true
There was a problem hiding this comment.
Great idea, updated!
mschauer
approved these changes
Aug 10, 2017
andyferris
reviewed
Aug 11, 2017
| @@ -135,4 +135,6 @@ | |||
| @test Tuple{2, 3, 5} != StaticArrays.Size{(2, 3, 4)} | |||
| @test StaticArrays.Size{(2, 3, 4)} != Tuple{2, 3, 5} | |||
| @test StaticArrays.check_length(2) == nothing | |||
|
|
|||
| @test convert(Tuple, @SVector [2]) == (2,) | |||
There was a problem hiding this comment.
I tend to use === for isbits immutables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.