-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maximum(A, d), sum(A, d), ... should give an SMatrix for A::SMatrix #65
Comments
No... we shouldn't even do what is happening now (return To do this properly, we would need something like JuliaLang/julia#17880 (simultaneous inlining and inference) so that we have some way of constant-propagating the dimension you are selecting to reduce over inside another function. Is this a function you find you use a lot? I almost never do, but maybe that is just me. (I would use things like sum(rand(SMatrix{3,3}), Val{2}) |
I'm using it in a package I'm working on, but it's not that performance-critical. |
Generated a PR addressing this: #86 |
Now that #86 is merged, |
I'm going to close this... I think |
Currently, this is using the generic reduction code:
The text was updated successfully, but these errors were encountered: