Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow known failures in FillArrays reshape test #354

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 26, 2024

These tests don't really belong here, and we were testing for a lack of method ambiguities. These need to be fixed in FillArrays (or Base).

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (3b94d64) to head (9a5f06b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files           6        6           
  Lines         453      453           
=======================================
  Hits          447      447           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 000a042 into master Jun 26, 2024
17 checks passed
@jishnub jishnub deleted the jishnub/fillarraytests branch June 26, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant