fix deprecated syntax: Wrapping Vararg directly in UnionAll #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syntax like this seems to be deprecated: `inds::Vararg{<:Integer,N}`,
so I removed the `<:`.
```
$ julia -O3 --min-optlevel=3 --depwarn=error --warn-overwrite=yes
_
_ _ _(_)_ | Documentation: https://docs.julialang.org
(_) | (_) (_) |
_ _ _| |_ __ _ | Type "?" for help, "]?" for Pkg help.
| | | | | | |/ _` | |
| | |_| | | | (_| | | Version 1.10.0-DEV.453 (2023-01-28)
_/ |\__'_|_|_|\__'_| | Commit 7d4309c9c31 (0 days old master)
|__/ |
julia> using OffsetArrays
[ Info: Precompiling OffsetArrays [6fe1bfb0-de20-5000-8ca7-80f57d26f881]
ERROR: LoadError: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
Stacktrace:
[1] UnionAll(v::TypeVar, t::Any)
@ Core ./boot.jl:257
[2] top-level scope
@ ~/tmp/OffsetArrays.jl/src/OffsetArrays.jl:660
```
Fixes #324
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 5 5
Lines 452 452
=======================================
Hits 446 446
Misses 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks good! Could you bump the patch version? I'll merge and tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax like this seems to be deprecated:
inds::Vararg{<:Integer,N}, so I removed the<:.Fixes #324