limit type-piracy in getindex #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 5 5
Lines 422 422
=======================================
Hits 402 402
Misses 20 20
Continue to review full report at Codecov.
|
johnnychen94
approved these changes
Jun 26, 2021
|
Looks more like a "bug" fix to me so maybe v1.10.1 is more accurate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to address JuliaArrays/ArrayInterface.jl#170. Technically it's breaking, as it reverts #244 for custom
AbstractUnitRanges, however since ranges are treated to be equal based only on value, this won't lead to errors unless one specifically relies on the indices as computed in #244 for custom range types. Since that behavior was type-piracy anyway, I wonder if this may be treated as a minor change?In any case this may be a temporary fix if JuliaLang/julia#41284 is merged.