Specialize Base.cconvert for OffsetArrays (#344)

* Specialize Base.cconvert for OffsetArrays * Don't test for adjoint
JuliaArrays · Dec 20, 2023 · 62e0bd8 · 62e0bd8
1 parent e83d167
commit 62e0bd8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/OffsetArrays.jl b/src/OffsetArrays.jl
@@ -461,7 +461,10 @@ Base.copy(A::OffsetArray) = parent_call(copy, A)
 
 Base.strides(A::OffsetArray) = strides(parent(A))
 Base.elsize(::Type{OffsetArray{T,N,A}}) where {T,N,A} = Base.elsize(A)
-@inline Base.unsafe_convert(::Type{Ptr{T}}, A::OffsetArray{T}) where {T} = Base.unsafe_convert(Ptr{T}, parent(A))
+Base.cconvert(P::Type{Ptr{T}}, A::OffsetArray{T}) where {T} = Base.cconvert(P, parent(A))
+if VERSION < v"1.11-"
+    @inline Base.unsafe_convert(::Type{Ptr{T}}, A::OffsetArray{T}) where {T} = Base.unsafe_convert(Ptr{T}, parent(A))
+end
 
 # For fast broadcasting: ref https://discourse.julialang.org/t/why-is-there-a-performance-hit-on-broadcasting-with-offsetarrays/32194
 Base.dataids(A::OffsetArray) = Base.dataids(parent(A))

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -2481,6 +2481,8 @@ end
         @test pointer(a', 5) === pointer(parent(a), 5)
         @test pointer(A', 15) === pointer(parent(A)', 15)
     end
+
+    @test Base.cconvert(Ptr{eltype(A)}, A) == Base.cconvert(Ptr{eltype(A)}, parent(A))
 end
 
 # issue 171